Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feat: add kapp on kfd.yaml, update apply scripts #322

Merged
merged 14 commits into from
Dec 23, 2024

Conversation

nutellinoit
Copy link
Member

@nutellinoit nutellinoit commented Dec 6, 2024

Summary 💡

This PR introduces the application of manifests generated by kustomize (in both distribution and plugins phases) using the kapp CLI. Kapp allows for applying manifests and verifying that everything being installed is functioning correctly. It can also apply CRDs, wait for them to be available, and then apply the referring CRs. This significantly reduces and simplifies the complexity of apply operations, which were previously performed with plain kubectl.

Here's a breakdown of the changes:

  • kustomize manifests application: Instead of using kubectl apply, we now leverage kapp to manage manifest deployments.
  • Verification and functionality: Kapp ensures that all deployed resources are functioning correctly.
  • CRD handling: Kapp simplifies the process of applying CRDs and their associated CRs.
  • Future migration benefits: By utilizing kapp's state-based resource removal capabilities, migrations will be streamlined.

This PR brings significant improvements to our deployment and migration workflows by leveraging the powerful features of kapp.

Tests

The following manual tests were performed:

  • Tested cluster upgrade from KFD 1.30.0 (OnPremises provider) to KFD 1.31.0 with:
    • Loki
    • Opensearch
    • Kyverno
    • Gatekeeper
    • Tempo

Future work

This feature will allow for reduced migrations complexity in the future as kapp is capable of removing resources from the cluster leveraging a state (a secret), similar to helm.

@nutellinoit nutellinoit changed the base branch from main to feat/release-v1.31.0 December 6, 2024 15:00
@ralgozino ralgozino marked this pull request as ready for review December 18, 2024 11:05
@ralgozino ralgozino marked this pull request as draft December 18, 2024 11:05
@nutellinoit nutellinoit marked this pull request as ready for review December 23, 2024 09:53
@nutellinoit nutellinoit merged commit 2c85eac into feat/release-v1.31.0 Dec 23, 2024
1 check passed
@nutellinoit nutellinoit deleted the feat/use-kapp-instead branch December 23, 2024 09:53
@nutellinoit nutellinoit mentioned this pull request Dec 24, 2024
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants