chore: update opentelemetry swift #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbley
approved these changes
Apr 4, 2023
|
Investigating the test failure, it seems some of the spans are duplicated |
bgustafson
reviewed
Apr 4, 2023
| @@ -8,11 +8,23 @@ import Foundation | |||
| /// Implementation for the Span class that records trace events. | |||
| public class RecordEventsReadableSpan: ReadableSpan { | |||
| public var isRecording = true | |||
|
|
|||
| fileprivate let internalStatusQueue = DispatchQueue(label: "org.opentelemetry.RecordEventsReadableSpan.internalStatusQueue", attributes: .concurrent) | |||
There was a problem hiding this comment.
Could the duplicate spans be coming from otel creating spans from different threads? I am wondering if a serial queue would fix the problem.
There was a problem hiding this comment.
Was fixed with open-telemetry/opentelemetry-swift#400
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to bring in open-telemetry/opentelemetry-swift#379