-
Notifications
You must be signed in to change notification settings - Fork 18
Upgrade Twilio and dockerfile (python 3.13-slim) #110
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Ran into some issues due to twilio having removed their support for Fax in version 7.6.0 Current dependencies for reference are now:
|
@jpsantosbh Hello! Can you take a look at this when you have a chance? Should be ready to merge at this point as far as I can tell but let me know if you need anything else; all tests are passing for me locally right now. Thanks! |
Thanks @bnjmn could you sync this with main again? |
Bumps dockerfile to python:3.13-slim
Fax module was removed in Twilio 7.6.0 so pinning it before that.
@jpsantosbh done! Let me know if you need anything else on it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
@jpsantosbh Thank you for getting the merged. Will there be a new version of the python package released to pypi at some point to include this? |
@bnjmn it's published already https://pypi.org/project/signalwire/2.1.1/ |
Hey @jpsantosbh — thanks for the quick reply! I just took a look at the 2.1.1 release on PyPI and it looks like it was published back in February, before my PR was merged on April 2. It still shows twilio==6.54.0 in the dependencies, so I don’t think my changes made it into that release. Do you mind publishing a new version that includes the latest changes from main? Let me know if I can help! 🙏 |
I've upgraded Twilio and all dependencies in Pipfile. This requires minimum python 3.9 now which I believe is reasonable since 3.8 is EOL.
Here are the current versions that are installed for each package for reference (all tests currently passing on my machine.
(EDIT: See comment below for final versions)
Related to #85 – I tried python 3.13 and 3.12 but would also need to install
gcc
Duplicates #95
Closes #78
I suggest merging this and making a new 3.0 (or 2.2.0) release of SignalWire Python SDK if possible. That would be great; Thanks!