Skip to content

Upgrade Twilio and dockerfile (python 3.13-slim) #110

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

bnjmn
Copy link
Contributor

@bnjmn bnjmn commented Jan 3, 2025

I've upgraded Twilio and all dependencies in Pipfile. This requires minimum python 3.9 now which I believe is reasonable since 3.8 is EOL.

Here are the current versions that are installed for each package for reference (all tests currently passing on my machine.

(EDIT: See comment below for final versions)

root@b65291349603:/app# pipenv requirements
-i https://pypi.org/simple
aiohappyeyeballs==2.4.4; python_version >= '3.8'
aiohttp==3.11.11; python_version >= '3.9'
aiohttp-retry==2.8.3; python_version >= '3.7'
aiosignal==1.3.2; python_version >= '3.9'
attrs==24.3.0; python_version >= '3.8'
certifi==2024.12.14; python_version >= '3.6'
charset-normalizer==3.4.1; python_version >= '3.7'
frozenlist==1.5.0; python_version >= '3.8'
idna==3.10; python_version >= '3.6'
multidict==6.1.0; python_version >= '3.8'
propcache==0.2.1; python_version >= '3.9'
pyjwt==2.10.1; python_version >= '3.9'
pytz==2024.2
requests==2.32.3; python_version >= '3.8'
-e . ; python_version >= '3.6'
six==1.17.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2'
twilio==9.4.1; python_full_version >= '3.7.0'
urllib3==2.3.0; python_version >= '3.9'
yarl==1.18.3; python_version >= '3.9'

Related to #85 – I tried python 3.13 and 3.12 but would also need to install gcc
Duplicates #95
Closes #78

I suggest merging this and making a new 3.0 (or 2.2.0) release of SignalWire Python SDK if possible. That would be great; Thanks!

@bnjmn bnjmn changed the title Upgrade Twilio and dockerfile (python 3.11-slim) WIP Upgrade Twilio and dockerfile (python 3.13-slim) Jan 3, 2025
@bnjmn bnjmn marked this pull request as draft January 3, 2025 17:42
@bnjmn
Copy link
Contributor Author

bnjmn commented Jan 3, 2025

Ran into some issues due to twilio having removed their support for Fax in version 7.6.0

Current dependencies for reference are now:

root@4f4a07cb12a6:/app# pipenv requirements
-i https://pypi.org/simple
aiohappyeyeballs==2.4.4; python_version >= '3.8'
aiohttp==3.11.11; python_version >= '3.9'
aiosignal==1.3.2; python_version >= '3.9'
attrs==24.3.0; python_version >= '3.8'
certifi==2024.12.14; python_version >= '3.6'
charset-normalizer==3.4.1; python_version >= '3.7'
frozenlist==1.5.0; python_version >= '3.8'
idna==3.10; python_version >= '3.6'
multidict==6.1.0; python_version >= '3.8'
propcache==0.2.1; python_version >= '3.9'
pyjwt==2.10.1; python_version >= '3.9'
pytz==2024.2
requests==2.32.3; python_version >= '3.8'
-e . ; python_version >= '3.6'
six==1.17.0; python_version >= '2.7' and python_version not in '3.0, 3.1, 3.2'
twilio==7.5.1; python_full_version >= '3.6.0'
urllib3==2.3.0; python_version >= '3.9'
yarl==1.18.3; python_version >= '3.9'

@bnjmn bnjmn changed the title WIP Upgrade Twilio and dockerfile (python 3.13-slim) Upgrade Twilio and dockerfile (python 3.13-slim) Jan 3, 2025
@bnjmn bnjmn marked this pull request as ready for review January 3, 2025 18:05
@bnjmn
Copy link
Contributor Author

bnjmn commented Jan 3, 2025

@jpsantosbh Hello! Can you take a look at this when you have a chance? Should be ready to merge at this point as far as I can tell but let me know if you need anything else; all tests are passing for me locally right now. Thanks!

@jpsantosbh
Copy link
Contributor

Thanks @bnjmn could you sync this with main again?

bnjmn added 2 commits March 25, 2025 15:11
Bumps dockerfile to python:3.13-slim
Fax module was removed in Twilio 7.6.0 so pinning it before that.
@bnjmn
Copy link
Contributor Author

bnjmn commented Mar 25, 2025

@jpsantosbh done! Let me know if you need anything else on it. Thanks!

Copy link
Contributor

@jpsantosbh jpsantosbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jpsantosbh jpsantosbh merged commit cf7d2b4 into signalwire:master Apr 2, 2025
1 check passed
@bnjmn
Copy link
Contributor Author

bnjmn commented Apr 8, 2025

@jpsantosbh Thank you for getting the merged. Will there be a new version of the python package released to pypi at some point to include this?

@jpsantosbh
Copy link
Contributor

@bnjmn it's published already https://pypi.org/project/signalwire/2.1.1/

@bnjmn
Copy link
Contributor Author

bnjmn commented Apr 9, 2025

Hey @jpsantosbh — thanks for the quick reply! I just took a look at the 2.1.1 release on PyPI and it looks like it was published back in February, before my PR was merged on April 2. It still shows twilio==6.54.0 in the dependencies, so I don’t think my changes made it into that release.

Do you mind publishing a new version that includes the latest changes from main? Let me know if I can help! 🙏

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency issue with using an older version of Twilio library
2 participants