Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add getter for RequestId of TalkRequest #91

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Add getter for RequestId of TalkRequest #91

merged 1 commit into from
Oct 27, 2021

Conversation

jacobkaufmann
Copy link
Contributor

Expose the RequestId of a TalkRequest.

Motivation: Allow protocols built on top of discv5 to access request IDs of TalkRequest for e.g. logging.

@jacobkaufmann jacobkaufmann mentioned this pull request Oct 26, 2021
Merged
AgeManning
AgeManning approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@AgeManning AgeManning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me :)

@AgeManning AgeManning merged commit b7d8a84 into sigp:master Oct 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@AgeManning AgeManning AgeManning approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobkaufmann @AgeManning