Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Verify kzg_commitments_inclusion_proof on data column by range responses #6111

Closed
Tracked by #4983
jimmygchen opened this issue Jul 16, 2024 · 3 comments
Closed
Tracked by #4983

Verify kzg_commitments_inclusion_proof on data column by range responses #6111

jimmygchen opened this issue Jul 16, 2024 · 3 comments
Assignees
@dapplion
Labels
das Data Availability Sampling fulu Required for the upcoming Fulu hard fork

Comments

@jimmygchen
Copy link
Member

Description

See this comment #6044 (comment)

We shouldn't need to verify consistency of all kzg commitments against the block body, given that a valid inclusion proof must prevent this from happening. However this check don't currently exist on the DataColumnByRange response code path and should be added.
@jimmygchen jimmygchen added the das Data Availability Sampling label Jul 16, 2024
@jimmygchen jimmygchen mentioned this issue Jul 16, 2024
Closed
@jimmygchen jimmygchen mentioned this issue Aug 21, 2024
Closed
52 tasks
@jimmygchen
Copy link
Member Author

I believe this is addressed in #6851

@dapplion dapplion reopened this Feb 3, 2025
@dapplion
Copy link
Collaborator

dapplion commented Feb 3, 2025

To be closed by

@jimmygchen jimmygchen added the fulu Required for the upcoming Fulu hard fork label Feb 4, 2025
@jimmygchen
Copy link
Member Author

#6497 has been merged

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@dapplion dapplion

Labels
das Data Availability Sampling fulu Required for the upcoming Fulu hard fork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jimmygchen @dapplion