Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use data column batch verification consistently #6851

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

dapplion
Copy link
Collaborator

@dapplion dapplion commented Jan 23, 2025

Issue Addressed

Resolve a TODO(das) to use KZG batch verification in put_rpc_custody_columns

Proposed Changes

Uses verify_kzg_for_data_column_list_with_scoring in all paths that send more than one column. To use batch verification and have attributability of which peer is sending a bad column.

Needs to move verify_kzg_for_data_column_list_with_scoring into the type's module to convert to the KZG verified type.

@dapplion dapplion added ready-for-review The code is ready for review das Data Availability Sampling labels Jan 23, 2025
@dapplion dapplion mentioned this pull request Jan 25, 2025
52 tasks
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Jan 30, 2025
@dapplion dapplion requested a review from jxs as a code owner February 1, 2025 05:03
@dapplion dapplion added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 1, 2025
Copy link
Member

@jimmygchen jimmygchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Feb 3, 2025
mergify bot added a commit that referenced this pull request Feb 3, 2025
@mergify mergify bot merged commit 95cec45 into sigp:unstable Feb 3, 2025
31 checks passed
@dapplion dapplion deleted the kzg-batch-peerdas branch February 3, 2025 14:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants