Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Deterministic RNG in peer DAS publish block tests #6296

Open
michaelsproul opened this issue Aug 22, 2024 · 1 comment
Open

Deterministic RNG in peer DAS publish block tests #6296

michaelsproul opened this issue Aug 22, 2024 · 1 comment
Assignees
@SunnysidedJ
Labels
code-quality das Data Availability Sampling test improvement Improve tests

Comments

@michaelsproul
Copy link
Member

michaelsproul commented Aug 22, 2024 •
edited by dapplion
Loading

Description

It would be good to make the tests deterministic by using a seeded RNG here:

#5683 (comment)

lighthouse/beacon_node/http_api/src/publish_blocks.rs

Line 128 in ea331a9

data_col_sidecars.shuffle(&mut rand::thread_rng());

@michaelsproul michaelsproul added test improvement Improve tests code-quality das Data Availability Sampling labels Aug 22, 2024
@michaelsproul michaelsproul mentioned this issue Aug 22, 2024
Merged
@SunnysidedJ
Copy link

SunnysidedJ commented Mar 20, 2025 •
edited
Loading

Hi, I'm a new joinee from Sunnyside Labs and I'd like to work on it. Thanks!

SunnysidedJ added a commit to SunnysidedJ/lighthouse that referenced this issue Mar 21, 2025
@SunnysidedJ
Initial fix for sigp#6296: Deterministic RNG in peer DAS publish bloc…
60d3745 
…k tests
@SunnysidedJ SunnysidedJ mentioned this issue Mar 21, 2025
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@SunnysidedJ SunnysidedJ

Labels
code-quality das Data Availability Sampling test improvement Improve tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaelsproul @SunnysidedJ