Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update test vectors to v1.1.0 #2642

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Update test vectors to v1.1.0 #2642

merged 1 commit into from
Sep 28, 2021

Conversation

michaelsproul
Copy link
Member

@michaelsproul michaelsproul commented Sep 28, 2021 •
edited
Loading

Bump test vectors to v1.1.0. Main changes:

  • Fix merge genesis initialization by calling upgrade_to_merge and overriding some parameters. This beats re-implementing initialize_beacon_state_from_eth1 IMO.
  • Adjust the palceholder terminal_total_difficulty value

@michaelsproul michaelsproul added ready-for-review The code is ready for review merge-f2f Relates to the Oct 2021 Merge F2F labels Sep 28, 2021
@michaelsproul
Copy link
Member Author

Ah missed some files. Will fix.

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 28, 2021
@michaelsproul michaelsproul added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 28, 2021
@michaelsproul
Copy link
Member Author

New genesis tests added and passing 👍

Ignoring the PowBlock tests as our PowBlock includes extra fields compared to the spec: https://github.com/ethereum/consensus-specs/blob/v1.1.0/specs/merge/fork-choice.md#powblock

paulhauner
paulhauner approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@paulhauner paulhauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulhauner paulhauner merged commit 1fd4c8e into sigp:merge-f2f Sep 28, 2021
@michaelsproul michaelsproul deleted the spec-test-v1.1.0 branch September 28, 2021 04:20
paulhauner pushed a commit that referenced this pull request Sep 28, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
7236dcb
paulhauner pushed a commit that referenced this pull request Oct 1, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
ef372fd
paulhauner pushed a commit that referenced this pull request Oct 12, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
ec0d1c3
paulhauner pushed a commit that referenced this pull request Oct 27, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
2f2267b
paulhauner pushed a commit to paulhauner/lighthouse that referenced this pull request Nov 3, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (sigp#2642)
e4e5590
paulhauner pushed a commit that referenced this pull request Nov 11, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
0fc5564
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
d3cb188
paulhauner pushed a commit that referenced this pull request Nov 28, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
2015617
paulhauner pushed a commit that referenced this pull request Dec 2, 2021
@michaelsproul @paulhauner
Update test vectors to v1.1.0 (#2642)
fd82819
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@paulhauner paulhauner paulhauner approved these changes

Assignees
No one assigned
Labels
merge-f2f Relates to the Oct 2021 Merge F2F ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelsproul @paulhauner