Ensure db paths are backwards compatible #2843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawanjay176
force-pushed
the
bc-directory
branch
from
ef18cb5 to
e82260d
Compare
|
Closing this in favour of #2846 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
N/A
Proposed Changes
#2682 fixed a bug where providing a relative path for datadir resulted in the datadir db paths being created relative to the home directory. However, as @paulhauner noted in the PR, this would be a backwards incompatible change for users relying on the bug knowingly or unknowingly.
This PR ensures backwards compatibility by keeping the db in the same place as before for users relying on the bug.
If there is no db in the existing location, then it will behave as expected (create a directory relative to the current path).