Prevent Kurtosis container pollution #6441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
added
test improvement
jimmygchen
added
ready-for-merge
|
Oh yeah i noticed this too and I was nuking the docker containers. |
|
@Merigfyio queue |
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at dd08ebb |
5 tasks
chong-he
pushed a commit
to chong-he/lighthouse
that referenced
this pull request
Nov 26, 2024
* Prevent Kurtosis container pollution
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
After using the kurtosis testnet scripts I was left with autostarting Docker containers for
traefikandtimberio/vector. Given thattraefikcan open tunnels and expose ports to the internet I would prefer that it doesn't randomly auto start on my machine.Proposed Changes
Add
kurtosis engine stoptostop_local_testnet.shso that all Kurtosis-related containers are stopped when the script ends.This may be a bit aggressive, as some users may want to run multiple testnets in parallel. I'm open to stopping the engine by default and having a flag to avoid stopping it, if that would be useful?
Additional Info
Discussion on Kurtosis discord: https://discord.com/channels/783719264308953108/1131048810861314169/1289051346947018846