Increase jemalloc aarch64 page size limit (#5244) #6831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass JEMALLOC_SYS_WITH_LG_PAGE=16 to aarch64 cross-compilation to support systems with up to 64-KiB page sizes.
|
|
michaelsproul
added
under-review
also add JEMALLOC_SYS_WITH_LG_PAGE to `build-lcli-aarch64` target
michaelsproul
added
ready-for-review
michaelsproul
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Looks good.
I added the page size info to lighthouse --version so we can confirm when the setting is taking effect.
I had issues with Cargo not detecting the setting of the env var, like:
- Build without env var
- Build with env var (no-op, but should rebuild)
I think this is maybe just something to be aware of. A cargo clean between 1 and 2 will sort it out.
michaelsproul
added
ready-for-merge
|
Added the |
6 tasks
|
Some benchmarks on my Mac showed an insignificant (~1%) difference between 16K pages (default on macOS) and 64K pages, when it came to CPU performance of |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#5244
Proposed Changes
Pass
JEMALLOC_SYS_WITH_LG_PAGE=16env to aarch64 cross-compilation to support systems with up to 64-KiB page sizes. This is backwards-compatible for the current (most usual) 4-KiB systems.