Remove un-used batch sync error condition #6917
Conversation
dapplion
requested review from
AgeManning and
jimmygchen
and removed request for
jxs
| .get_mut(peer_id) | ||
| .map(|active_requests| active_requests.remove(&batch_id)); | ||
|
|
||
| let received = batch.download_completed(blocks)?; |
There was a problem hiding this comment.
Now it's a regular WrongState error, we can just ?
| @@ -265,40 +265,21 @@ impl<T: BeaconChainTypes> SyncingChain<T> { | |||
| } | |||
| }; | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
Remove this unnecessary closure
|
@mergify queue |
🛑 The pull request has been removed from the queue
|
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
jimmygchen
added
ready-for-merge
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
- PR sigp#6497 made obsolete some consistency checks inside the batch I forgot to remove the consumers of those errors Remove un-used batch sync error condition, which was a nested `Result<_, Result<_, E>>`
michaelsproul
added
blocked
and removed
ready-for-merge
|
Removing from merge queue temporarily while we merge v7 PRs |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@mergify requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
- PR sigp#6497 made obsolete some consistency checks inside the batch I forgot to remove the consumers of those errors Remove un-used batch sync error condition, which was a nested `Result<_, Result<_, E>>`
- PR sigp#6497 made obsolete some consistency checks inside the batch I forgot to remove the consumers of those errors Remove un-used batch sync error condition, which was a nested `Result<_, Result<_, E>>`
Issue Addressed
I forgot to remove the consumers of those errors
Proposed Changes
Remove un-used batch sync error condition, which was a nested
Result<_, Result<_, E>>