Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove err impossible condition: nil != nil #1934

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

Horiodino
Copy link
Contributor

Summary

fixes: #1933

Release Note

Documentation

Signed-off-by: Horiodino <holiodin@gmail.com>
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.11%. Comparing base (cf238ac) to head (cbeeffa).
Report is 293 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1934      +/-   ##
==========================================
- Coverage   57.93%   52.11%   -5.82%     
==========================================
  Files          50       73      +23     
  Lines        3119     5643    +2524     
==========================================
+ Hits         1807     2941    +1134     
- Misses       1154     2429    +1275     
- Partials      158      273     +115     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit c828ca3 into sigstore:main Jan 31, 2025
13 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove err impossible condition: nil != nil
2 participants