Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cue policy in test file for two attestations does not work. #130

Open
vaikas opened this issue Aug 4, 2022 · 3 comments
Open

Cue policy in test file for two attestations does not work. #130

vaikas opened this issue Aug 4, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@vaikas
Copy link
Collaborator

vaikas commented Aug 4, 2022

Description
The following is a CIP policy json that's being evaluated:

{
  "authorityMatches": {
    "keyatt": {
      "signatures": null,
      "attestations": {
        "custom-match-predicate": [
          {
            "subject": "",
            "issuer": ""
          }
        ]
      }
    },
    "keylesssignature": {
      "signatures": [
        {
          "subject": "https://kubernetes.io/namespaces/default/serviceaccounts/default",
          "issuer": "https://kubernetes.default.svc/"
        }
      ],
      "attestations": null
    },
    "keysignature": {
      "signatures": [
        {
          "subject": "",
          "issuer": ""
        }
      ],
      "attestations": null
    }
  }
}

It is incorrectly passing with this policy file here:
https://github.com/sigstore/policy-controller/blob/main/test/testdata/policy-controller/e2e/cip-requires-two-signatures-and-two-attestations.yaml
And in particular here:
https://github.com/sigstore/policy-controller/blob/main/test/testdata/policy-controller/e2e/cip-requires-two-signatures-and-two-attestations.yaml#L95

Version

@vaikas vaikas added the bug Something isn't working label Aug 4, 2022
vaikas referenced this issue in vaikas/policy-controller Aug 4, 2022
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
hectorj2f pushed a commit that referenced this issue Aug 4, 2022
@hectorj2f hectorj2f self-assigned this Sep 22, 2022
@hectorj2f
Copy link
Collaborator

I believe this has been fixed!

@vaikas
Copy link
Collaborator Author

vaikas commented Jan 30, 2023

@vaikas
Copy link
Collaborator Author

vaikas commented Apr 11, 2023

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants