Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

upgrade Go to 1.21 #1017

Merged
merged 4 commits into from
Oct 5, 2023
Merged

upgrade Go to 1.21 #1017

merged 4 commits into from
Oct 5, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 2, 2023

Summary

  • upgrade Go to 1.21

@cpanato
upgrade Go to 1.21
9d729f0 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato cpanato marked this pull request as draft October 2, 2023 13:32
@cpanato
fix lints
af3d4d6 
Signed-off-by: cpanato <ctadeu@gmail.com>
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #1017 (77b5175) into main (9549aca) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1017   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          44       44           
  Lines        4841     4841           
=======================================
  Hits         2648     2648           
  Misses       1977     1977           
  Partials      216      216
Files Coverage Δ
pkg/config/store.go 100.00% <ø> (ø)

@cpanato cpanato marked this pull request as ready for review October 2, 2023 14:24
@bobcallaway
Copy link
Member

should we use https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file to avoid having to change a bunch of these files in the future?

@cpanato
Copy link
Member Author

cpanato commented Oct 2, 2023

should we use https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file to avoid having to change a bunch of these files in the future?

not strong opinion here, will make the change to use that

@cpanato
Copy link
Member Author

cpanato commented Oct 5, 2023

ping @vaikas @bobcallaway

@cpanato
use go-version-file in the setup-go action
4bb781d 
Signed-off-by: cpanato <ctadeu@gmail.com>
bobcallaway
bobcallaway previously approved these changes Oct 5, 2023
View reviewed changes
hectorj2f
hectorj2f previously approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpanato
fix checkout order
77b5175 
Signed-off-by: cpanato <ctadeu@gmail.com>
hectorj2f
hectorj2f approved these changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hectorj2f hectorj2f merged commit 0bea93e into sigstore:main Oct 5, 2023
@github-actions github-actions bot added this to the v1 milestone Oct 5, 2023
@cpanato cpanato deleted the upgrade-gp branch October 5, 2023 14:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hectorj2f hectorj2f hectorj2f approved these changes

@vaikas vaikas Awaiting requested review from vaikas

@bobcallaway bobcallaway Awaiting requested review from bobcallaway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1
Development

Successfully merging this pull request may close these issues.
3 participants
@cpanato @bobcallaway @hectorj2f