Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add check for ACR registry in ACR credential helper #1658

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

codysoyland
Copy link
Member

Summary

This PR adds a check that will only run the ACR credential helper when the target registry is a subdomain of azurecr.io.

This is similar to an existing check used for GCR.

Fixes #1657

Release Note

Documentation

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.18%. Comparing base (50ef092) to head (a4d3b49).
Report is 249 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1658       +/-   ##
===========================================
- Coverage   52.92%   42.18%   -10.75%     
===========================================
  Files          44      121       +77     
  Lines        3979     7190     +3211     
===========================================
+ Hits         2106     3033      +927     
- Misses       1651     3802     +2151     
- Partials      222      355      +133     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codysoyland
Copy link
Member Author

The original issue seems to be resolved by #1656, which merged earlier today.

I still think this PR is good to merge, as it will speed things along slightly if ACR is not used, but the fix has basically been implemented.

@hectorj2f
Copy link
Collaborator

Thanks @codysoyland although there is one CI check failing.

Signed-off-by: Cody Soyland <codysoyland@github.com>
@codysoyland codysoyland force-pushed the fix-azure-credhelper-block branch from 9338cb1 to a4d3b49 Compare October 9, 2024 21:19
@codysoyland codysoyland requested a review from hectorj2f October 10, 2024 00:14
@hectorj2f hectorj2f merged commit 9decba2 into sigstore:main Oct 31, 2024
71 of 72 checks passed
@github-actions github-actions bot added this to the v1 milestone Oct 31, 2024
senanz pushed a commit to senanz/policy-controller that referenced this pull request Nov 3, 2024
Signed-off-by: Cody Soyland <codysoyland@github.com>
Signed-off-by: Senan Zedan (EXT-Nokia) <senan.zedan.ext@nokia.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACR credential helper blocks when using non-ACR registries
3 participants