Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update snippets to use console type for snippets #410

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

tiziano88
Copy link
Contributor

shell or bash expects the entire snippet to be a bash script, while console highlights only lines prefixed with $ as bash.

@dlorenc
Copy link
Member

dlorenc commented Aug 11, 2021

Whoa! I had no idea this was a thing!

@cpanato cpanato added this to the v0.4.0 milestone Aug 11, 2021
@tiziano88
Copy link
Contributor Author

Me neither until 5 minutes ago! I was reading the readme and thought that there must be a proper way of highlighting those snippets, and finally ended up on https://github.com/github/linguist/blob/7efa7b3380ad0221c499f9ef1ca84c4dfcc0b299/lib/linguist/languages.yml#L5594-L5605 , which works!

BTW the DCO is complaining that my commit (which I authored from the web UI) is not signed..... I guess I need to do a proper one from my laptop and force push.

I must say I don't really understand what signing commits actually buys you though.

@cpanato
Copy link
Member

cpanato commented Aug 11, 2021

@tiziano88 thanks for the PR
yes, you need to do git commit --amend --no-edit --signoff and push again

`shell` or `bash` expects the entire snippet to be a bash script, while `console` highlights only lines prefixed with `$` as bash.

Signed-off-by: Tiziano Santoro <tiziano88@gmail.com>
@tiziano88
Copy link
Contributor Author

Done now.

@dlorenc dlorenc merged commit ec97584 into sigstore:main Aug 13, 2021
@cpanato cpanato modified the milestones: v0.4.0, v1.0.0 Aug 25, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants