Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cleanup the output of search (the text goes to stderr not stdout). #421

Merged
merged 1 commit into from
Aug 22, 2021
+3 −8
Merged

Cleanup the output of search (the text goes to stderr not stdout). #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions cmd/rekor-cli/app/search.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,7 @@ type searchCmdOutput struct {
}

func (s *searchCmdOutput) String() string {
str := "No matching entries were found\n"
for i, uuid := range s.uuids {
if i == 0 {
str = "Found matching entries (listed by UUID):\n"
}
str += fmt.Sprintf("%v\n", uuid)
}
return str
return strings.Join(s.uuids, "\n") + "\n" // one extra /n to terminate the list
}

func addSearchPFlags(cmd *cobra.Command) error {
Expand Down Expand Up @@ -203,6 +196,8 @@ var searchCmd = &cobra.Command{
return nil, fmt.Errorf("no matching entries found")
}

fmt.Fprintln(os.Stderr, "Found matching entries (listed by UUID):")

return &searchCmdOutput{
uuids: resp.GetPayload(),
}, nil
Expand Down