move cache to WeakMap

siimon · Mar 12, 2023 · dcb5c3f · dcb5c3f
1 parent f1f2dfd
commit dcb5c3f
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/registry.js b/lib/registry.js
@@ -219,14 +219,16 @@ function formatLabels(labels) {
 	);
 }
 
+const sharedLabelCache = new WeakMap();
 function flattenSharedLabels(labels) {
-	if (labels.__flattened_internal) {
-		return labels.__flattened_internal;
+	const cached = sharedLabelCache.get(labels);
+	if (cached) {
+		return cached;
 	}
 
 	const formattedLabels = formatLabels(labels);
 	const flattened = formattedLabels.join(',');
-	Object.defineProperty(labels, '__flattened_internal', { value: flattened });
+	sharedLabelCache.set(labels, flattened);
 	return flattened;
 }
 function escapeLabelValue(str) {