Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Exclude all CodeQL code-scanning queries of "Note" severity #1402

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

@imnasnainaec imnasnainaec self-assigned this Feb 26, 2025
@imnasnainaec imnasnainaec marked this pull request as ready for review February 26, 2025 14:00
@imnasnainaec
Copy link
Contributor Author

imnasnainaec commented Feb 26, 2025

@tombogle I see two rules (cs/missed-readonly-modifier and cs/xmldoc/missing-summary) cluttering your current pr and thought you might have input on what to exclude.

Copy link

github-actions bot commented Feb 26, 2025

Palaso Tests

     4 files  ±0       4 suites  ±0   15m 5s ⏱️ - 3m 10s
 4 902 tests ±0   4 674 ✅ ±0  228 💤 ±0  0 ❌ ±0 
15 957 runs  ±0  15 273 ✅ ±0  684 💤 ±0  0 ❌ ±0 

Results for commit 9cc0d02. ± Comparison against base commit 3813e6c.

♻️ This comment has been updated with latest results.

@imnasnainaec
Copy link
Contributor Author

imnasnainaec commented Feb 26, 2025

A simple alternative to specific "note" exclusions would be to switch from security-and-quality to security-extended.

EDIT: This dropped too many rules, so working on filtering by severity instead.

@imnasnainaec imnasnainaec marked this pull request as draft February 26, 2025 21:00
@imnasnainaec imnasnainaec marked this pull request as ready for review February 26, 2025 21:24
@imnasnainaec imnasnainaec changed the title Exclude some CodeQL code-scanning notes Exclude all CodeQL code-scanning queries of "Note" severity Feb 27, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant