SF-3089 Show message when draft could not be added to the chapter #3014
Conversation
RaymondLuong3
added
the
will require testing
| await this.draftHandlingService.applyChapterDraftAsync(this.textDocId!, this.draftDelta); | ||
| this.isDraftApplied = true; | ||
| this.userAppliedDraft = true; | ||
| } catch { |
There was a problem hiding this comment.
What if it isn't a network error? Can we make sure to handle those differently, so we still get reports in Bugsnag, and shown to the user?
There was a problem hiding this comment.
Or just log everything to Bugsnag, even though network connection issues aren't really bugs. It would be nice to have something to refer to, just in case.
There was a problem hiding this comment.
Thanks, I have updated this to report errors to bugsnag silently unless it is a network related issue.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3014 +/- ##
=======================================
Coverage 82.65% 82.65%
=======================================
Files 553 553
Lines 32010 32016 +6
Branches 5186 5187 +1
=======================================
+ Hits 26458 26464 +6
Misses 4795 4795
Partials 757 757 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Nateowami)
| await this.draftHandlingService.applyChapterDraftAsync(this.textDocId!, this.draftDelta); | ||
| this.isDraftApplied = true; | ||
| this.userAppliedDraft = true; | ||
| } catch { |
There was a problem hiding this comment.
Or just log everything to Bugsnag, even though network connection issues aren't really bugs. It would be nice to have something to refer to, just in case.
RaymondLuong3
force-pushed
the
fix/sf-3089-re-add-draft
branch
from
d0cd9c6 to
6f25dcf
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @josephmyers and @Nateowami)
| await this.draftHandlingService.applyChapterDraftAsync(this.textDocId!, this.draftDelta); | ||
| this.isDraftApplied = true; | ||
| this.userAppliedDraft = true; | ||
| } catch { |
There was a problem hiding this comment.
Thanks, I have updated this to report errors to bugsnag silently unless it is a network related issue.
|
I am good with this is if @Nateowami is |
If the user tries to add a draft to a chapter, it can fail if the internet connectivity is poor. This change notifies the user if a draft fails to be applied.
This change is