Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Cow - work out why non-recipes ended up with new deps #33

Closed
emteknetnz opened this issue Mar 24, 2023 · 2 comments
Closed

Cow - work out why non-recipes ended up with new deps #33

emteknetnz opened this issue Mar 24, 2023 · 2 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Mar 24, 2023

Investigate why cow did this to admin

silverstripe/silverstripe-admin@dceb3e8

It shouldn't have - was reverted in this PR - silverstripe/silverstripe-admin#1480

Note only did this for 4.13-beta1, haven't seen this happen for anything else including 5.0.0-beta1, so this is low priority
This happened to most if not all non-recipes and will result in a bad constraint on stable if we don't fix it now.

There's a list of affected modules in a comment below. When reviewing, make sure each affected module has a PR (in case I missed one)

PRs

@GuySartorelli GuySartorelli self-assigned this Mar 28, 2023
@GuySartorelli GuySartorelli changed the title Cow - work out why admin ended up with new deps Cow - work out why non-recipes ended up with new deps Mar 28, 2023
This was referenced Mar 28, 2023
This was referenced Mar 28, 2023
@GuySartorelli
Copy link
Member

The following modules were affected. When reviewing this work, make sure there's a PR for each of these:

  • silverstripe/assets
  • silverstripe/config
  • silverstripe/mimevalidator
  • silverstripe/asset-admin
  • silverstripe/campaign-admin
  • silverstripe/versioned-admin
  • silverstripe/siteconfig
  • silverstripe/versioned
  • silverstripe/session-manager
  • silverstripe/#-forms
  • silverstripe/documentconverter
  • silverstripe/iframe
  • silverstripe/spellcheck
  • silverstripe/tagfield
  • silverstripe/taxonomy
  • silverstripe/blog
  • silverstripe/widgets
  • silverstripe/spamprotection
  • silverstripe/akismet
  • silverstripe/comments
  • silverstripe/comment-notifications
  • silverstripe/contentreview
  • silverstripe/sharedraftcontent
  • symbiote/silverstripe-advancedworkflow
  • silverstripe/segment-field
  • silverstripe/userforms
  • silverstripe/externallinks
  • silverstripe/securityreport
  • silverstripe/sitewidecontent-report
  • bringyourownideas/silverstripe-maintenance
  • bringyourownideas/silverstripe-composer-update-checker
  • silverstripe/restfulserver
  • silverstripe/versionfeed
  • silverstripe/elemental-fileblock
  • cwp/cwp-search
  • silverstripe/fulltextsearch
  • symbiote/silverstripe-queuedjobs
  • cwp/cwp-core
  • silverstripe/auditor
  • silverstripe/environmentcheck
  • silverstripe/hybridsessions
  • silverstripe/registry
  • silverstripe/totp-authenticator
  • silverstripe/mfa
  • silverstripe/crontask
  • silverstripe/gridfieldqueuedexport
  • silverstripe/ldap
  • silverstripe/textextraction
  • silverstripe/realme
  • silverstripe/ckan-registry
  • silverstripe/webauthn-authenticator
  • silverstripe/security-extensions
  • cwp/cwp
  • cwp/cwp-pdfexport
  • dnadesign/silverstripe-elemental-userforms
  • symbiote/silverstripe-multivaluefieldsilverstripe/cms
  • silverstripe/errorpage
  • silverstripe/reports
  • silverstripe/subsites
  • silverstripe/elemental-bannerblock
  • cwp/starter-theme

@GuySartorelli
Copy link
Member

All PRs merged

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants