Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIX Only change constraints for recipes #242

Conversation

GuySartorelli
Copy link
Member

Bad logic in cow resulted in many non-recipes having their constraints updated automatically when the beta was released.
Only recipes should have their constraints updated.

Issue

Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and sensible. I'm assuming you tried this locally and are confident it will work?

@GuySartorelli
Copy link
Member Author

I am confident it'll work. But I can't do a dry run with it until the PRs are merged that set the correct constraints to start with.
Once those are merged I'll do a dry run.

@GuySartorelli
Copy link
Member Author

This has been approved and I've confirmed in a dry-run that it works as expected.
Merging.

@GuySartorelli GuySartorelli merged commit d87063a into silverstripe:master Mar 28, 2023
@GuySartorelli GuySartorelli deleted the pulls/master/only-change-recipe-constraints branch March 28, 2023 21:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants