Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

DOC Do not use self #528

Merged
merged 1 commit into from
Jun 17, 2024
Merged

DOC Do not use self #528

merged 1 commit into from
Jun 17, 2024

Conversation

emteknetnz
Copy link
Member

Issue #486

@emteknetnz emteknetnz mentioned this pull request Jun 5, 2024
Closed
5 tasks
GuySartorelli
GuySartorelli approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 880bd04 into silverstripe:5.2 Jun 17, 2024
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.2/noself branch June 17, 2024 21:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli