Support buildstack changes for other modules #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
changed the title
|
Setting this to draft for now - I'll run a final yarn build when I'm sure I won't be making any other changes. |
I thought these would have come automatically, but it turns out they need to be independently exposed and added to externals config.
Creating a new emotion cache for each provider can result in clashes
GuySartorelli
force-pushed
the
pulls/2/support-buildstack-changes
branch
from
6b803eb to
4a1b488
Compare
sabina-talipova
approved these changes
Jan 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to avoid issues, e.g. with multiple copies of
@emotionbeing loaded byreact-select/creatablevsreact-selectvsreact-select/asyncin different modules. If they're all exposed from the same source (admin), they all use the same copy of@emotionand therefore there are no conflicts or issues with css from different react-select components.Parent issue