MNT Get JS tests passing again #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Feb 9, 2023
| @@ -14,6 +14,7 @@ describe('CampaignAdminItem', () => { | |||
| beforeEach(() => { | |||
| props = { | |||
| sectionConfig: { | |||
| reactRoutePath: '', | |||
There was a problem hiding this comment.
This is new for CMS 5 and isn't allowed to be missing.
| @@ -8,6 +8,7 @@ import React from 'react'; | |||
| import { Component as CampaignAdminList } from '../CampaignAdminList'; | |||
| import Enzyme, { shallow } from 'enzyme'; | |||
| import Adapter from 'enzyme-adapter-react-16'; | |||
| import { setImmediate } from 'core-js'; | |||
There was a problem hiding this comment.
https://stackoverflow.com/a/68724767/10936596
Fixes ReferenceError: setImmediate is not defined which is test-specific.
2 tasks
GuySartorelli
force-pushed
the
pulls/2/js-tests
branch
from
00259d1 to
7b868cd
Compare
emteknetnz
approved these changes
Feb 13, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See silverstripe/silverstripe-asset-admin#1330 for a wider discussion of most changes here
Parent issue