Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CMS 5 Pattern library doesn't work anymore #2842

Closed
maxime-rainville opened this issue Mar 19, 2023 · 4 comments
Closed

CMS 5 Pattern library doesn't work anymore #2842

maxime-rainville opened this issue Mar 19, 2023 · 4 comments

Comments

@maxime-rainville
Copy link
Contributor

maxime-rainville commented Mar 19, 2023

When upgrading Admin for CMS5 we didn't update the pattern library.

Acceptance criteria

  • Pattern library is updated to work with CMS5
  • Storybook is updated to the latest version
  • All existing stories are functional.
  • All modules using storybook are updated.
  • https://silverstripe.github.io/silverstripe-pattern-lib is generated from the CMS5 branches.
  • Add a dedicated doc page explaining what the pattern library does and how to use it.

Notes

  • yarn pattern-lib to build the the pattern library.

Related issue

PRs

@emteknetnz
Copy link
Member

I spent the better part of a day on this, it seems like it's fairly difficult to get this going

Recommend whoever picks this up again (if we even bother) approaches this from a "rebuild" mentality rather than an "upgrade" mentality

@emteknetnz
Copy link
Member

@sabina-talipova I've merged the PRs you created - there's still this draft PR though - silverstripe/silverstripe-pattern-lib#3

https://github.com/silverstripe/silverstripe-pattern-lib is used to build a static version of the pattern-lib each day which is hosted on a github page at https://silverstripe.github.io/silverstripe-pattern-lib/ - are you happy to ensure this is working as it should?

@sabina-talipova
Copy link
Contributor

I have created new ticket to fix 4 spaces indent issue and make additional enhancement.

@sabina-talipova
Copy link
Contributor

All PRs have been merged. Close this issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants