Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MNT Support Storybook v7 #1361

Merged

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented May 24, 2023

Description

Updates for @storybook/addon-knobs to support Storybook v7:

Parent issue

@sabina-talipova sabina-talipova marked this pull request as ready for review May 25, 2023 03:23
@sabina-talipova sabina-talipova force-pushed the pulls/2/storybook-update branch 5 times, most recently from 74c37c7 to 9a716f9 Compare May 29, 2023 00:12
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the UPD prefix on the commit and pull-request to MNT instead - https://docs.silverstripe.org/en/5/contributing/code/#commit-messages

@sabina-talipova sabina-talipova changed the title UPD Support Storybook v7 MNT Support Storybook v7 May 30, 2023
@sabina-talipova sabina-talipova force-pushed the pulls/2/storybook-update branch from 9a716f9 to 4a548a1 Compare May 30, 2023 20:52
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll create a separate card to deal with the 4 space indent which should be a 2 space indent

@emteknetnz emteknetnz merged commit 87a661e into silverstripe:2 May 30, 2023
@emteknetnz emteknetnz deleted the pulls/2/storybook-update branch May 30, 2023 22:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants