Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

API Remove deprecated code #1169

Merged
merged 1 commit into from
Apr 17, 2024
Merged

API Remove deprecated code #1169

merged 1 commit into from
Apr 17, 2024

Conversation

emteknetnz
Copy link
Member

Issue #329

@emteknetnz emteknetnz mentioned this pull request Apr 17, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/6/remove-deprecated-2 branch from aaa1705 to a3a9992 Compare April 17, 2024 06:16
GuySartorelli
GuySartorelli approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any immediate problems with this, we'll see what happens after the follow-up cards, but for now this seems okay.

@GuySartorelli GuySartorelli merged commit 1512b17 into silverstripe:6 Apr 17, 2024
13 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-deprecated-2 branch April 17, 2024 22:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli