Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

API rescue master-branch PR: Use Generators for ORM #10450

Merged
merged 4 commits into from
Aug 29, 2022
Merged

API rescue master-branch PR: Use Generators for ORM #10450

merged 4 commits into from
Aug 29, 2022

Conversation

GuySartorelli
Copy link
Member

This PR rescues #6518 from the master branch. See the original PR for discussion about the implementation.

Note that yield results in returning a Generator which is a subclass of Iterator - so all getIterator() methods affected now explicitly return Iterator

Parent Issue

@GuySartorelli GuySartorelli mentioned this pull request Aug 11, 2022
Closed
5 tasks
@GuySartorelli GuySartorelli force-pushed the pulls/5/rescue-master-generators branch 3 times, most recently from 7dbe29d to 3b10a68 Compare August 11, 2022 01:58
@GuySartorelli GuySartorelli marked this pull request as draft August 11, 2022 03:20
@GuySartorelli GuySartorelli mentioned this pull request Aug 11, 2022
Merged
@GuySartorelli GuySartorelli force-pushed the pulls/5/rescue-master-generators branch from 721feda to bd817eb Compare August 11, 2022 03:39
@GuySartorelli
Copy link
Member Author

This will fail on postgres because a separate module needs to be updated for those tests to pass. That will be handled under silverstripe/silverstripe-postgresql#135
The easiest way forward is to merge this is only the postgres jobs are failing, and then rerun CI on the postgres-specific PR which will then need to be fully green to be merged.

@GuySartorelli GuySartorelli force-pushed the pulls/5/rescue-master-generators branch from bd817eb to 52c68fb Compare August 11, 2022 03:59
@GuySartorelli GuySartorelli force-pushed the pulls/5/rescue-master-generators branch from 52c68fb to 4cb36d4 Compare August 11, 2022 04:29
@GuySartorelli
Copy link
Member Author

The prefer lowest job is failing on the 5 branch so that failure can be disregarded for the purposes of this PR: https://github.com/silverstripe/silverstripe-framework/actions/runs/2837427036

@GuySartorelli GuySartorelli marked this pull request as ready for review August 11, 2022 04:57
@emteknetnz emteknetnz merged commit 9edf3a5 into silverstripe:5 Aug 29, 2022
@emteknetnz emteknetnz deleted the pulls/5/rescue-master-generators branch August 29, 2022 07:03
GuySartorelli added a commit to creative-commoners/silverstripe-framework that referenced this pull request Sep 1, 2022
@GuySartorelli
Revert "Merge pull request silverstripe#10450 from creative-commoners…
7eef05d 
…/pulls/5/rescue-master-generators"

This reverts commit 9edf3a5, reversing
changes made to 934fafd.
@GuySartorelli GuySartorelli mentioned this pull request Sep 1, 2022
Merged
emteknetnz pushed a commit that referenced this pull request Sep 1, 2022
@GuySartorelli
Revert "Merge pull request #10450 from creative-commoners/pulls/5/res…
06b13e0 
…cue-master-generators" (#10483)

This reverts commit 9edf3a5, reversing
changes made to 934fafd.
@GuySartorelli GuySartorelli mentioned this pull request Sep 2, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuySartorelli @emteknetnz @dhensby