Rescue Master Branch PR: Fix SQLConditionalExpression::getJoins so it always adds explicit aliases #10462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ases This is a revert of silverstripe#8956
5 tasks
emteknetnz
requested changes
Aug 24, 2022
|
I'm going to have a separate PR to update the changelog and update docs all in one PR to avoid having to clear up conflicts every time one of these is merged. I can start that now in a draft stage if you want to see that before merging this. |
|
All good, makes sense to do in one go |
emteknetnz
approved these changes
Aug 24, 2022
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescues #8966
This is a revert of #8956 which was always intended to be temporary.
Parent issue