Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DEP PHP Support in CMS5 #335

Merged

Conversation

sabina-talipova
Copy link
Contributor

@emteknetnz
Copy link
Member

Requires a ^2 version of https://github.com/tractorcow/silverstripe-proxy-db

@sabina-talipova
Copy link
Contributor Author

Passed tests in local env.
Requires PR to be merged first

Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe we want to create a subsite CMS5 PR before merging this. But I'm not too fuss either way.

@sabina-talipova
Copy link
Contributor Author

DONE

@maxime-rainville maxime-rainville merged commit fc415c3 into silverstripe:4 Jan 16, 2023
@maxime-rainville maxime-rainville deleted the pulls/4/upgrade-cms5 branch January 16, 2023 21:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants