Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make the write call of StringTagField::saveInto method configurable #208

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

dkliemsch
Copy link
Contributor

With that PR its possible to opt-out of the immediate write call within the saveInto method of the StringTagField using a custom config like this:

---
Name: app-tagfieldconfig
After:
  - tagfieldconfig
---
SilverStripe\TagField\StringTagField:
  immediate_write_enabled: false

@dhensby
Copy link
Contributor

dhensby commented Apr 1, 2022

I think we certainly need a test for this.

@dkliemsch
Copy link
Contributor Author

I think we certainly need a test for this.

I've added two tests with the option enabled/disabled, hope that's ok?

@michalkleiner michalkleiner merged commit 0a04e35 into silverstripe:2 Apr 4, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants