Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

maintenant ça build #403

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

maintenant ça build #403

wants to merge 7 commits into from

Conversation

r0one
Copy link
Contributor

@r0one r0one commented Nov 22, 2022

hésitez pas à lire les noms de commits pour comprendre mes choix

docker-compose.yml Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@r0one r0one marked this pull request as draft November 25, 2022 17:54
@r0one r0one force-pushed the fix/build branch 2 times, most recently from 11c580b to 201ef39 Compare November 25, 2022 18:04
@r0one r0one marked this pull request as ready for review November 25, 2022 18:22
@r0one r0one requested a review from cesar-richard November 25, 2022 18:22
Comment on lines +1 to +4
services:
database:
image: "mysql:5.6"
platform: "linux/amd64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pourquoi tu commit un docker override ?

@@ -34,6 +37,9 @@ services:
- /app/node_modules # FIME : Share dependencies with the host ? Comment to enable.
env_file:
- .env
environment:
NODE_OPTIONS: "--openssl-legacy-provider"
# TODO: upgrade webpack so that we can remove this option allowing the usage of deprecated crypto
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parfait ca ❤️

@@ -20,6 +20,9 @@ services:
- database
env_file:
- .env
environment:
"DB_HOST": "database"
"APP_KEY": "base64:zJQUL4236152JL697IJ+1UO7IUS42w2Td4069LNABfE="
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ca dispense de faire la commande artisan ca ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants