#343. add access token params in the profile picture url

[anklos]

According to new facebook API change, it requires access token to fetch user profile picture: https://developers.facebook.com/docs/graph-api/reference/user/picture/

This pull request adds access token param in the image url, which resolves the issue I posted #343

[anklos]

anyone still maintains this gem?

[simi]

yes, this is on my radar

[OlivierJM]

This looks great. @anklos @simi would the documentation need to be updated after this?

[simi]

@OlivierJM definitely. I'm just thinking if we should do this only for particular (API) version or just release new major version (of this gem) with API default changed to one related this change is related as well.

[OlivierJM]

I think a release for just this particular API change would do.

[tupakapoor]

Just wanted to leave a gentle reminder that these new requirements go live on Facebook on 10/24 😃

[simi]

OK, let's setup final plan.

Would adding access token for profile picture URL break old APIs?

[OlivierJM]

It doesn't look like It breaks the current APIs

@anklos kindly confirm am not much of a rails guy

[anklos]

@OlivierJM can confirm it does not. I am running my forked version on production.

[anklos]

@simi it does not break old APIs, which just ignore the access_token query params in picture url

[OlivierJM]

awesome, sounds good. what would you recommend we update in the documentation ?

@simi it looks like we are good to go on this.

[anklos]

@OlivierJM could mention that new version supports facebook API changes for profile picture (https://developers.facebook.com/docs/graph-api/reference/user/picture/)

[OlivierJM]

awesome, thanks.

[simi]

released as 8.0.0

[OlivierJM]

Thanks a lot @simi