Feature/add kinesis resource detection #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug in the # api where we did not pass region in the # request.
kaplanelad
suggested changes
Jun 14, 2020
cregev
commented
Jun 14, 2020
kaplanelad
approved these changes
Jun 14, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Backend Feature
Bug fix
What this PR does / why we need it:
This PR adds the ability to detect unutilized Kinesis data streams.
Which issue(s) this PR fixes (if exists):
This PR fixes an issue in Finala's AWS # manager.
Until this PR each # API request issued used only the region
us-east-1.Now we pass the relevant region for all # API requests