Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor to use source-map-explorer, enabling usage with Ember CLI, ember-auto-import and Embroider #26

Merged
merged 19 commits into from
Feb 8, 2023

Conversation

simonihmig
Copy link
Owner

@simonihmig simonihmig commented Jun 18, 2019

Closes #24

To Do:

  • Test rebuild
  • Assert for working sourcemap settings (ember-cli + ember-auto-import/webpack)
  • Filter out webpack://__ember_auto_import__/ - possible?
  • Test CSS sourcemaps
  • Test Embroider
  • Docs

@simonihmig simonihmig force-pushed the sourcemaps branch 2 times, most recently from 7721a24 to c3d94d7 Compare June 18, 2019 08:49
@evoactivity
Copy link

Just ran this branch on my app but it only seemed to output for my CSS files. Is this currently expected? (considering it's a WIP)

@simonihmig
Copy link
Owner Author

Is this currently expected?

No, certainly not. I tested it with the addon's dummy app, and was working. Maybe you have sourcemaps disabled?

@evoactivity
Copy link

No I have them enabled explicitly, I can see stats have been generated in the concat-stats-for directory but no JS is shown in the output from source-map-explorer. I've tried on a different app and see the output I'd expect so definitely something in my app breaking it.

@simonihmig simonihmig changed the title WIP: Refactor to use source-map-explorer Refactor to use source-map-explorer Dec 30, 2022
@simonihmig simonihmig mentioned this pull request Dec 30, 2022
@simonihmig simonihmig changed the title Refactor to use source-map-explorer Refactor to use source-map-explorer, enabling usage with Ember CLI, ember-auto-import and Embroider Feb 2, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor to use sourcemaps for analysis
2 participants