Handle Date and RegExp Objects

[ctwoolsey]

No description provided.

[pzuraq]

I'm no longer actively maintaining this library and unfortunately do not have the bandwidth to review/merge this change. Happy to pass permissions/ownership along to someone who can look after it.

[ctwoolsey]

Thank you Chris, As I'm using this library in my project right now, I would like permissions so that I can update this project with this change and future changes. Thank you, Clark Woolsey

…

On Wed, Dec 1, 2021 at 4:06 PM Chris Garrett ***@***.***> wrote: I'm no longer actively maintaining this library and unfortunately do not have the bandwidth to review/merge this change. Happy to pass permissions/ownership along to someone who can look after it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD6QVRS62IT6B73SXBANO4TUOY2WLANCNFSM5JEC46TA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[ctwoolsey]

Hi Chris, If you get a chance and give me permissions, I can go ahead and merge my pull request. Thank you, Clark Woolsey On Wed, Dec 1, 2021 at 5:46 PM Clark Woolsey ***@***.***> wrote:

…

Thank you Chris, As I'm using this library in my project right now, I would like permissions so that I can update this project with this change and future changes. Thank you, Clark Woolsey On Wed, Dec 1, 2021 at 4:06 PM Chris Garrett ***@***.***> wrote: > I'm no longer actively maintaining this library and unfortunately do not > have the bandwidth to review/merge this change. Happy to pass > permissions/ownership along to someone who can look after it. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#112 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AD6QVRS62IT6B73SXBANO4TUOY2WLANCNFSM5JEC46TA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

[simonihmig]

@ctwoolsey I already have permissions on this repo, and could handle your PR. However I have some concerns here.

First, it seems to be a bad practice to store mutable instances in the store. I am not a redux pro, but this is what their own docs say:

Redux actions and state should only contain plain JS values like objects, arrays, and primitives. Don't put class instances, functions, or other non-serializable values into Redux!.

Since we can't just put a Date class instance into the Redux store, we'll track the post.date value as a timestamp string:

Second, even when that was acceptable, I would ask you to provide some tests for your changes.