imp: allow timestamp syntax in transaction dates #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes it possible to specify timestamps in hledger transactions. For example: 2024-01-01 12:43:56+09:00. All existing logic that uses the transaction's date information has been left unchanged - that is to say, the time of day is not used anywhere yet. The intention behind this is to modify such logic in future commits/pull requests. Furthermore, backwards compatibility with existing ledgers using plain dates has been fully preserved (barring any bugs that I missed). ref: simonmichael#117
|
Thanks for this @Stealthmate. When you have a chance, rebase it and fix failing checks and I'll check it out. |
simonmichael
added
A-WISH
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes it possible to specify timestamps in hledger transactions. For example: 2024-01-01 12:43:56+09:00. All existing logic that uses the transaction's date information has been left unchanged - that is to say, the time of day is not used anywhere yet. The intention behind this is to modify such logic in future commits/pull requests.
Furthermore, backwards compatibility with existing ledgers using plain dates has been fully preserved (barring any bugs that I missed).
ref: #117