Skip to content

Handle case where new keys are added to JSON objects (--format json) #13

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
simonw opened this issue Feb 23, 2021 · 2 comments
Open

Handle case where new keys are added to JSON objects (--format json) #13

simonw opened this issue Feb 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Feb 23, 2021

Right now if the first JSON object is missing keys that are present in the second JSON object the script crashes.
@simonw simonw added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Feb 23, 2021
@simonw
Copy link
Owner Author

simonw commented Feb 23, 2021

I'm going to fix this by having the load_json() function normalize the JSON it loads it so any missing keys from any of the objects become keys against null.

simonw added a commit that referenced this issue Feb 23, 2021
@simonw
Handle missing JSON keys, refs #13
33e0a59
simonw added a commit to CAVaccineInventory/vaccinate-ca-history that referenced this issue Feb 23, 2021
@simonw
Try latest csv-diff bug fix
cf1f64b 
Refs simonw/csv-diff#13
@simonw
Copy link
Owner Author

simonw commented Feb 23, 2021

I'll close this issue once I've seen my production deployment of this fix work correctly for a while.

simonw added a commit that referenced this issue Sep 6, 2024
@simonw
Release 1.2
ebb8c42 
Refs #11, #13, #38
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw