Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

"Show all columns" cog menu item should show if ?_col= is used #1341

Closed
simonw opened this issue May 27, 2021 · 1 comment
Closed

"Show all columns" cog menu item should show if ?_col= is used #1341

simonw opened this issue May 27, 2021 · 1 comment
Labels
bug

Comments

@simonw
Copy link
Owner

simonw commented May 27, 2021

On https://latest.datasette.io/fixtures/sortable?_col=sortable the "Show all columns" item (from #615) is not shown (it should be):

fixtures__sortable__201_rows
@simonw simonw added the bug label May 27, 2021
@simonw
Copy link
Owner Author

simonw commented May 27, 2021

For implementation simplicity I'm going to show the item even if all of the columns are visible because ?_col= has selected all of them - selecting it will still reset the view to having no ?_col= or ?_nocol= parameters.

@simonw simonw closed this as completed in 51d7881 May 27, 2021
simonw added a commit that referenced this issue May 27, 2021
@simonw
Release 0.57a1
7b106e1 
Refs #1319, #1320, #1331, #1337, #1338, #1341
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw