Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

In 4.0 change default floating point column type to REAL #645

Open
simonw opened this issue Nov 23, 2024 · 1 comment
Open

In 4.0 change default floating point column type to REAL #645

simonw opened this issue Nov 23, 2024 · 1 comment
Labels
bug Something isn't working
Milestone
4.0 backwards inc...

Comments

@simonw
Copy link
Owner

simonw commented Nov 23, 2024

This is a bug in 3.x but it only causes problems with strict tables. In 4.0 we should switch from FLOAT to REAL in the CREATE TABLE used for all floating point columns.

Split from #644 (comment)
@simonw simonw added the bug Something isn't working label Nov 23, 2024
simonw added a commit that referenced this issue Nov 23, 2024
@simonw
Use REAL for floating point columns if table is strict, closes #644
4dc2e2e 
Refs #645
@chapmanjacobd
Copy link
Contributor 

            if strict and column_type_str == "FLOAT":
                column_type_str = "REAL"

also needs to be in Table.add_column

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.0 backwards incomatible changes
Development

No branches or pull requests
2 participants
@simonw @chapmanjacobd