Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[puppetsync] Don't ignore Puppet 8 failures #65

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

silug
Copy link
Contributor

@silug silug commented Jun 12, 2024

Puppet 8 failures should not be ignored.

Also

  • Use the correct Ruby version for Puppet 8 tests
  • Manage spec/spec_helper.rb in Puppet modules

@silug silug force-pushed the 20240612-puppet8-tests branch 5 times, most recently from fe372b5 to 46ae4d1 Compare June 18, 2024 15:41
@silug silug force-pushed the 20240612-puppet8-tests branch 2 times, most recently from e6d1df6 to 84a32d6 Compare July 8, 2024 18:59
Puppet 8 failures should not be ignored.

Also
* Use the correct Ruby version for Puppet 8 tests
* Manage spec/spec_helper.rb in Puppet modules
@silug silug force-pushed the 20240612-puppet8-tests branch from 84a32d6 to f64f2e5 Compare July 10, 2024 19:47
Copy link
Contributor

@rgardner4012 rgardner4012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👻

@rgardner4012 rgardner4012 merged commit 0e18365 into simp:master Jul 11, 2024
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants