-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Google Photos takeout sometimes missing media extension in supplemental-metadata.json
file
#674
Comments
More examples:
I appear to have 15 examples of this in my full Google Photos Takeout archive. |
Edit: nevermind, this approach doesn't work. It causes issues for files that shouldn't match because of indices (such as
immich-go/adapters/googlePhotos/matchers.go Lines 12 to 16 in 3bdf4b5
|
Interesting The takeout system has already difficulties to handle long file names, making the pairing of JSON with image tricky. The latest RC addresses this problem. But your sample is new for me. So I have to refactor the matcher routines |
You can help by providing the list of the files as delivered in the takeout files. For privacy, you can DM the list on my discord account @simulot |
I'm sorry, but I don't feel comfortable sharing the full list, even privately over discord. I do want to help out, though. Are any of these alternatives acceptable?
|
Sure, your feeling is perfectly valid. The need is to have realistic set of photos and related JSON files as delivered by the takeout procedure. I just need the file names, not their content. Apparently the length of the file's base name matter, not the path. I have found some strange results with names having UTF-8 chars. Until now, I have encountered
Your example shows another way to mangle long file names
The JSON file structure seams to be unchanged. Thank you for your input. |
Sorry, I'm not quite following. Would it be useful for me to send you a full list of files, but with the album names redacted? Or are you saying that's not useful because even if I preserve the number of characters in the album name, it might not be the same number of bytes in a utf8 encoding, and that's what you really need to know? |
The album name doesn't matter AFAIK. You can redact them. It's better to not redact file names. You can just omit files name with private information More samples you give, more chances I have to determine a rule that works with your case while not breaking the existing ones |
For example, see:
Note how
Peanut Butter Balls.supplemental-metadata.json
does not include thejpg
extension, which confounds all our matchers.I'm not sure if there's a good fix for this. Would it be too risky to also try removing the media extension to look for a match?
The text was updated successfully, but these errors were encountered: