Fix alfy-init freezing with some editors (e.g. vim) #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
When you have a
config.json
file in your project, during installationalfy-init
is gonna call alfred-config to copy this file and open on the default editor.There's a problem when you have a terminal-based editor such as
vim
set,postinstall
script is gonna freeze waiting for the editor to close, but it's never visible for the user in the first place, so you'll be stuck.This PR tries to fix this issue by inheriting
stdio
.If you wanna try to reproduce this, simply create a
config.json
file in your alfy project, runEDITOR=vim npm install
and you should be stuck as well.