Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add TypeScript definition #188

Merged
merged 11 commits into from
Mar 21, 2019
Merged

Add TypeScript definition #188

merged 11 commits into from
Mar 21, 2019

Conversation

BendingBender
Copy link
Contributor

@BendingBender BendingBender commented Mar 7, 2019 •
edited
Loading

Waiting for tsdjs/tsd#13 until this can be merged.

sindresorhus
sindresorhus requested changes Mar 10, 2019
View reviewed changes
@sindresorhus
Copy link
Owner

Let me know if you have any feedback on how the execa API could be improved, especially regarding making TS usage easier. We're planning to do a major version, so we could do breaking changes to improve the UX.

@sindresorhus
Copy link
Owner

Waiting for tsdjs/tsd#13 until this can be merged.

Make sure you check out the latest changes in master when you get back to the types here. There are some API changes.

@sindresorhus sindresorhus added this to the v2 milestone Mar 10, 2019
@BendingBender
Copy link
Contributor Author

Let me know if you have any feedback on how the execa API could be improved, especially regarding making TS usage easier. We're planning to do a major version, so we could do breaking changes to improve the UX.

It's actually hard to say for me, I don't really use this module.

My only problem with the current API is the usage of encoding: null to switch to Buffer encoding. I know that this is how node APIs work, I still find it quite unnatural. However, for the sake of compatibility with node, I'd leave it like this.

@BendingBender BendingBender changed the title WIP: Add TypeScript definition Add TypeScript definition Mar 15, 2019
sindresorhus
sindresorhus requested changes Mar 15, 2019
View reviewed changes
@sindresorhus sindresorhus requested a review from ehmicky March 15, 2019 11:20
ehmicky
ehmicky reviewed Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@ehmicky ehmicky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sindresorhus
Copy link
Owner

sindresorhus commented Mar 19, 2019 •
edited
Loading

@BendingBender Can you update for #193 ? I'm trying to remove most of the null usage.

@BendingBender
Copy link
Contributor Author

Yeah, it's on my radar 😜

@sindresorhus
Copy link
Owner

And also 79356cc

@BendingBender
Copy link
Contributor Author

BendingBender commented Mar 20, 2019 •
edited
Loading

Waiting for tsdjs/tsd#19

@sindresorhus sindresorhus merged commit 3db7d2c into sindresorhus:master Mar 21, 2019
@ehmicky ehmicky mentioned this pull request May 15, 2019
Closed
mikeharder added a commit to mikeharder/azure-sdk-for-js that referenced this pull request Dec 6, 2019
@mikeharder
Remove unused @types dev dependencies
7b1d76b 
- dotenv
  - Types are included as of 8.2.0
  - motdotla/dotenv#430
- execa
  - Types are included as of 2.0.0
  - sindresorhus/execa#188
- nock
  - Types are included as of 11.3
  - nock/nock#1670
@mikeharder mikeharder mentioned this pull request Dec 6, 2019
Merged
mikeharder added a commit to Azure/azure-sdk-for-js that referenced this pull request Dec 9, 2019
@mikeharder
Remove unused @types dev dependencies (#6458)
aad3495 
- dotenv
  - Types are included as of 8.2.0
  - motdotla/dotenv#430
- execa
  - Types are included as of 2.0.0
  - sindresorhus/execa#188
- nock
  - Types are included as of 11.3
  - nock/nock#1670
@dependabot dependabot bot mentioned this pull request Mar 14, 2021
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ehmicky ehmicky ehmicky left review comments

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
3 participants
@BendingBender @sindresorhus @ehmicky