Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor tests of kill() #284

Merged
merged 2 commits into from
Jun 12, 2019
Merged

Refactor tests of kill() #284

merged 2 commits into from
Jun 12, 2019

Conversation

ehmicky
Copy link
Collaborator

@ehmicky ehmicky commented Jun 12, 2019

This is a follow-up to #272 and #280 adding more refactoring to kill():

  • remove some newlines in tests
  • improve test titles
  • add one test (when forceKill is true)
  • fix description in typings not matching the description in readme

@zokker13

@sindresorhus sindresorhus merged commit 7e2c835 into master Jun 12, 2019
@sindresorhus sindresorhus deleted the feature/refactor-kill-v3 branch June 12, 2019 17:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants