Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ability to detect MPEG when prefixed with some noise #646

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Ability to detect MPEG when prefixed with some noise #646

wants to merge 1 commit into from

Conversation

Borewit
Copy link
Collaborator

@Borewit Borewit commented Jul 16, 2024 •
edited
Loading

Allow 4 bytes of prefixing MPEG noise.

Via options.mpegOffsetTollerance this number can be increased, which will result it a bit slow scanning times.

Resolves #628

ToDo

  • Document options.mpegOffsetTollerance
  • Add MPEG noise fixture
  • Handle corner case options.mpegOffsetTollerance exceed 256 (peeked buffer size) - 2 (MPEG preamble) [bytes]

@Borewit Borewit self-assigned this Jul 16, 2024
@Borewit Borewit marked this pull request as draft July 16, 2024 21:20
@Borewit Borewit added the improvement Improvement of existing functionality label Aug 14, 2024
@Borewit Borewit requested review from sindresorhus and removed request for sindresorhus August 14, 2024 09:38
@sindresorhus sindresorhus force-pushed the main branch 2 times, most recently from 5b9fdd9 to 0e91f7b Compare September 12, 2024 07:06
@Borewit Borewit mentioned this pull request Dec 2, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@Borewit Borewit

Labels
improvement Improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom detectors running after default detectors
1 participant
@Borewit