Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

More HTTPS tests #1704

Merged
merged 5 commits into from
May 5, 2021
Merged

More HTTPS tests #1704

merged 5 commits into from
May 5, 2021

Conversation

Giotino
Copy link
Collaborator

@Giotino Giotino commented Apr 28, 2021

HTTPS tests for ciphers, honorCipherOrder, minVersion https options

Checklist

  • I have read the documentation.
  • I have included a pull request description of my changes.
  • I have included some tests.

sindresorhus
sindresorhus reviewed Apr 28, 2021
View reviewed changes
test/https.ts Outdated Show resolved Hide resolved
Giotino and others added 2 commits April 28, 2021 13:28
@Giotino @sindresorhus
Update test/https.ts
4e7d301 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@Giotino
Update https.ts
e90dde5
szmarczak
szmarczak reviewed Apr 28, 2021
View reviewed changes
test/https.ts Outdated Show resolved Hide resolved
szmarczak
szmarczak reviewed Apr 28, 2021
View reviewed changes
test/https.ts Outdated Show resolved Hide resolved
@szmarczak szmarczak changed the title HTTPS tests from #1435 More HTTPS tests May 5, 2021
@szmarczak szmarczak merged commit fe723a0 into sindresorhus:main May 5, 2021
@szmarczak
Copy link
Collaborator

Good job! 💛

@Giotino Giotino deleted the https-tests branch May 5, 2021 12:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sindresorhus sindresorhus sindresorhus left review comments

@szmarczak szmarczak szmarczak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Giotino @szmarczak @sindresorhus