Move default condition last #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
There's a compilation error happening with Next.js when using
math-clampv2.2.0:However, it doesn't happen with v2.1.0. It was most likely caused by #14 because it's the only commit contained in v2.2.0.
More specifically caused by the changes in
package.jsonwhere adefaultexports entry was added and was not the last one, as the error indicates.As reference, a similar issue was reported in firebase-js-sdk. The root cause was the same, a PR where
package.jsonchanged in a similar matter. The solution was to move the entry to be last as shown in this PR.This PR attempts to fix the issue in the same way.
Feel free to let me know if I should make further changes.
Thanks!